[stable11] Backport of Fix Broken UUID Attribute Detection #3521#3528
Merged
Conversation
Fix integration test by not relying on Fake instances Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Fix determining the UUID attribute, default of the override is null Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> add integration test for uuid attr detection Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Add repair steps Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Background jobs can take 4k of characters only. We find a good batch size. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> add tests to DB group Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers. |
LukasReschke
requested changes
Feb 18, 2017
LukasReschke
left a comment
LukasReschke
left a comment
Member
There was a problem hiding this comment.
Tests seem to fail. Can you check on that?
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
Author
I knew exactly this would fail on exactly this point. 🤔 Anyway, resolved, |
MorrisJobke
approved these changes
Feb 20, 2017
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Looks good and didn't explode 👍
LukasReschke
approved these changes
Feb 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.